what and where to name show icons?

[Wakalaka]

I have "folder.jpg" in F:\I Shouldnt Be Alive and the show's folder icon is drawn, but the recordings in the folder show no icon, no matter what I name the file in F:\I Shouldnt Be Alive. This is with the 1.2.9 PVRX2.exe.

The patch you attached now displays icons for all recordings in the folder. I renamed media\art to media\xyz and the only JPG file in F:\I Shouldnt Be Alive is folder.jpg.

[sub]

Does it look for the show icon, named after the show (and without the timestamp), in media\art?

No it doesnt.

Or does it expect the timestamp as well

Yes

that would make no sense

Yes it does. Its for people that want to have a specific image for each episode, and the fall back logic for the default image if a specific one doesnt exist.

People can press the MAKE_THUMBNAIL key while watching a recording if they think there is a scene worth capturing as the specific image.

If that file isn't found, does it look for "folder.jpg" in the directory for the show on your defined PVR drive (in my case F:\)?

Yes, it always looks for a folder.jpg in the recording directory. For the default install, this would be the directory matching the show name. For example, d:\recordings\Friends\folder.jpg would be used for all episodes of Friends that hadnt otherwise defined a recording-specific screenshot (including timestamp).

Does GBPVR use media\art, or is that other plugins?

No, GB-PVR doesnt know anything about that directory. It must be some other plugin you're thinking of.

[Wakalaka]

I believe XRecord used media\art, probably why I have it (because I used to use XRecord).

So was it a bug in 1.2.9 PVRX2.exe that made the folder icon appear, but not the icon for each recording in the folder, for "F:\I Shouldnt Be Alive"? I had folder.jpg in there.

Or is there different criteria for finding a folder icon vs a recording icon?

[sub]

So was it a bug in 1.2.9 PVRX2.exe that made the folder icon appear, but not the icon for each recording in the folder, for "F:\I Shouldnt Be Alive"? I had folder.jpg in there.

It was a fault around the handling of special characters like ' that caused the folder.jpg to not be found. If this show name didnt have this character then it would have found the 'folder.jpg' file for each of the recordings.

[Wakalaka]

So would you say the fault handler was written incorrectly? Why were some characters chosen to be invalid, and thus cause a fault?

[sub]

I've answered this question about three times in this thread already. I'm not sure what exactly you're to hear, but given the patch fixed it, I think you should stop talking about it now.

[Wakalaka]

I'm not trying to cause trouble for you, so please don't get upset by my trying to understand how your SW is working. I missed the part about valid Windows filename, sorry for making that mistake. I love GB-PVR, only trying to make it better by reporting bugs and suggestions.

' is a valid character in a Windows filename, so I was confused why it was excluded and thought there might be a bug somewhere.

There are several characters that are stripped from the show name when constructing a filename to make sure we end up with a valid windows filename. :/\?*'`%><| and a few others.

[sub]

' is a valid character in a Windows filename, so I was confused why it was excluded and thought there might be a bug somewhere.

Yes, but it was added to the list of characters removed for my convenience to make some other logic simpler in the app.

[Wakalaka]

Fair enough, appreciate the help. Time to make my yearly donation (not tied to your helping me). Thanks!