File Naming conflicting with Comclean4

[bernlin2000]

Hi, I'm new to the forums and I have to say gb-pvr is a very slick program. Overall, everything was setup very quickly and all my recordings look very good (and sound excellent). However, I've been having problems with two shows: Law & Order and Law & Order: Criminal Intent. When these two programs are being post-processed (I just run them through comskip and comclean4 all all default settings) comclean4 always fails to make a "cleaned" version of these two shows. All my other shows get cleaned just fine, but these two don't. I noticed that comclean4 creates new folders for the demuxed video and sound files called "Law Order" and "Law Order Criminal Intent". I'm thinking that there's some sort of issue with the "&" character. Is there any way to have gb-pvr remove that before post-processing, or is there any other method that can get comclean4 to work with these two shows?

[sub]

Sorry, no there isnt. This isnt really a GB-PVR problem though, so you should try asking the author of comclean4 to fix this.

You might be able to come up with some scheme in your PostProcessing.bat to rename files to remove this character, but I'm no batch file expert so wouldnt be able to provide you any useful pointers on doing this.

[bernlin2000]

It looks like I might have to figure out some way to get rid of the "&" character. I'd rather not go back and rename every file, cause then gb-pvr won't recognize it as a file it recorded. I'm surprised I couldn't find anyone else that's had this issue. For Law & Order, all the .m2v and .mp2 files are in a new folder called "Law Order", but it apparently fails to multiplex them back.

[sub]

I'm surprised I couldn't find anyone else that's had this issue.

The majority of people dont trust comskip enough to trust the ads to be cut out, so there isnt many people using comclean. Comskip does a good job, but not that good. Instead most people just allow GB-PVR to skip the ads at playback time.

[pastro]

Hi, I'm new to the forums and I have to say gb-pvr is a very slick program. Overall, everything was setup very quickly and all my recordings look very good (and sound excellent). However, I've been having problems with two shows: Law & Order and Law & Order: Criminal Intent. When these two programs are being post-processed (I just run them through comskip and comclean4 all all default settings) comclean4 always fails to make a "cleaned" version of these two shows. All my other shows get cleaned just fine, but these two don't. I noticed that comclean4 creates new folders for the demuxed video and sound files called "Law Order" and "Law Order Criminal Intent". I'm thinking that there's some sort of issue with the "&" character. Is there any way to have gb-pvr remove that before post-processing, or is there any other method that can get comclean4 to work with these two shows?

Not sure what your batch file looks like but try putting the parameter for comclean in quotes.

[sub]

Yeah, thats a good point.

[bernlin2000]

I just use the standard comclean4 .bat file...

@echo on
Rem comclean4.bat Version 0.0.1
Rem Adapt to your framerate times 100 (PAL=2500/NTSC=2997)
set framerate=2997
Rem Adapt to where mpeg2schnitt.exe can be found
set mpeg2schnitt="D:\Program Files\mpeg2schnitt\mpeg2schnitt.exe"

rem Initialize the variables
set start=0
set duration=0

rem Set the command line start
set cmdline=%mpeg2schnitt% /S /E /Z "%~dpn1_clean.m2v" "%~dpn1.m2v"
set cutpoints=

rem Process all the lines from the Comskip output file
for /F "usebackq tokens=1,2,3*" %%i in ("%~dpn1.txt") do call :processline %%i %%j
rem Output last clip
call :totime %start%
set cmdline=%cmdline% /i%start%
echo Resulting cutpoints: %cutpoints%
rem echo %cmdline% >"%~dpn1.bat"
rem echo exit >>"%~dpn1.bat"
rem start /wait /low call "%~dpn1.bat"
@echo on
bbdmux "%~dpn1.mpg" 0xe0 "%~dpn1.m2v"
bbdmux "%~dpn1.mpg" 0xc0 "%~dpn1.mp2"
Echo Remove the commercials
%cmdline%
del "%~dpn1*.idd"
del "%~dpn1.m2v"
del "%~dpn1.mp2"

Rem Mulxiplex again to a regular mpeg file
mplex1 "%~dpn1_clean.m2v" "%~dpn1_clean.mp2" "%~dpn1_clean.mpg"
del "%~dpn1_clean.m2v"
del "%~dpn1_clean.mp2"

Rem RENAME the old .mpg file and rename the new one to the old name
rem if EXIST "%~dpn1_clean.mpg" move "%~dpn1.mpg" "%~dpn1_original.mpg"
rem if EXIST "%~dpn1_clean.mpg" move "%~dpn1_clean.mpg" "%~dpn1.mpg"

@echo off
echo Resulting cutpoints: %cutpoints%
rem exit
goto :eof

:processline
rem Skip useless lines
set arg=%1
if "%arg:~0,4%"=="FILE" goto :eof
if "%arg:~0,4%"=="----" goto :eof

rem Output the clip information for the show part
set /a length=%1-%start%
set /a duration=%duration%+%length%
call :totime %duration%
set cutpoints=%cutpoints% %tim%

if "%start%"=="0" goto :nointime
if "%1"=="0" goto :nostartshow
set cmdline=%cmdline% /i%start%
:nointime
set cmdline=%cmdline% /o%1
:nostartshow
rem Remember start of next clip
set start=%2
goto :eof

:totime
set tim=
if "%1"=="0" goto :eof
set /A position=%1 *100 / %framerate%
set /A hours=%position% / 60 /60
set /A hrest = %position% - %hours%*60*60
set /A minutes=%hrest% /60
set /A seconds = %hrest% - %minutes%*60
set tim=%hours%:%minutes%:%seconds%
goto eof
:eof

[pBS]

quotes should do it....but if not you can use the shortnames also..
"%~s1" would be the shortname version of %1...still need quotes as the & is in the first few letters..
"Law&Or~1.mpg"

i had same problem with Cats & Dogs.mpg so i use it to test with..

actually the batch looks ok..i believe it's a special char in dos that's why it's bombing..
[you can put 2 commands on one line with && between them and it'll always work..eg: dir \ && echo %cd%

for those i think i used just a regular %1 and it worked..fine...no interpretation happens..
there are other dos chars that will choke it also..so it needs to be fixed..and i know there's a way but it would need to be restructured a bit...
i'll check my batches and see how i got around it and let ya know..
i know for loops can obscure the bad chars..

[bernlin2000]

Thanks pBS, I have no experience with .bat files, so the syntax is totally new to me, I'll give that a shot

[pBS]

i think i found a problem...
:nointime
set cmdline=%cmdline% /o%1

i think the %1 there needs quotes..like /o"%~1"
because it isn't getting anything passed from calling routine,if "%start%"=="0" goto :nointime so %1 would be bat input params %1..[which probably need quotes]

after further review, that batch file has some apparent flow logic problems...like:

Code:

if "%start%"=="0" goto :nointime      << this goto will ALWAYS happen, cuz no branch away if not true.
if "%1"=="0" goto :nostartshow     <<same here, if not true, it still continues on to next line, then :notstartshow regardless.
set cmdline=%cmdline% /i%start%
:nointime
set cmdline=%cmdline% /o%1  <<always gets run
:nostartshow
rem Remember start of next clip
set start=%2  <<always gets run as well
goto :eof    <<this should be up 6 lines and here as well as a few other places.