Another place to look for possible speed improvements

[BrettB]

Can you reproduce the slow delete using this patch and repost the log?

Here you go.

[sub]

Can you reproduce the slow delete again, and collect both the mvp.log and nrecord.log?

[BrettB]

Can you reproduce the slow delete again, and collect both the mvp.log and nrecord.log?

Here you go. That time it only took about 2 seconds vs. the 10 seconds for the last test you had me do. Did you change something in there????

[sub]

No, not that I'm aware of, but other changes I've been working on may have inadvertently helped. I just tried to add some logging to see where was going slow. Unfortunately these logs dont really show any slowdown though, so it doesnt really pinpoint the cause. If you are able to get it to reproduce the problem, post the logs again and I'll take another look.

[BrettB]

OK, in both of these slow cases (the Big Brother and the first The Office), the recording that I was deleting was NOT something that I had just watched. Here are the relevant sections of the nrecord.logs for those 2 cases:

Code:

2011-07-17 09:50:59.876    [DEBUG][6]    DeleteRecording(21497)
2011-07-17 09:50:59.876    [DEBUG][6]    Cancelling wake up request for for 'RecordingOID21497'
2011-07-17 09:50:59.954    [DEBUG][6]     -removing: E:\NPVR Recordings\Big Brother\Big Brother_20110707_20002100.ts
2011-07-17 09:51:06.459    [DEBUG][6]     -removing: E:\NPVR Recordings\Big Brother\Big Brother_20110707_20002100.txt
2011-07-17 09:51:06.459    [DEBUG][6]     -removing: E:\NPVR Recordings\Big Brother\Big Brother_20110707_20002100.log
2011-07-17 09:51:06.459    [DEBUG][6]     -removing: E:\NPVR Recordings\Big Brother\Big Brother_20110707_20002100.edl
2011-07-17 09:51:06.459    [DEBUG][6]     -removing: E:\NPVR Recordings\Big Brother\Big Brother_20110707_20002100.jpg
2011-07-17 09:51:06.490    [DEBUG][6]    PlaybackPositionHelper.DeletePlaybackPosition(E:\NPVR Recordings\Big Brother\Big Brother_20110707_20002100.ts)
2011-07-17 09:51:06.662    [DEBUG][7]    Reloading recording schedule

and

Code:

2011-07-17 12:23:29.404    [DEBUG][15]    DeleteRecording(4055)
2011-07-17 12:23:29.405    [DEBUG][15]    Cancelling wake up request for for 'RecordingOID4055'
2011-07-17 12:23:29.475    [DEBUG][15]     -removing: D:\NPVR Recordings\The Office\The Office_20101007_20002030.ts
2011-07-17 12:23:37.215    [DEBUG][15]     -removing: D:\NPVR Recordings\The Office\The Office_20101007_20002030.txt
2011-07-17 12:23:37.216    [DEBUG][15]     -removing: D:\NPVR Recordings\The Office\The Office_20101007_20002030.log
2011-07-17 12:23:37.225    [DEBUG][15]     -removing: D:\NPVR Recordings\The Office\The Office_20101007_20002030.edl
2011-07-17 12:23:37.230    [DEBUG][15]     -removing: D:\NPVR Recordings\The Office\The Office_20101007_20002030.jpg
2011-07-17 12:23:37.236    [DEBUG][15]    PlaybackPositionHelper.DeletePlaybackPosition(D:\NPVR Recordings\The Office\The Office_20101007_20002030.ts)
2011-07-17 12:23:37.428    [DEBUG][7]    Reloading recording schedule

So, in both cases, the long delay was removing the .ts file.

Both drive D: and drive E: are internal, SATA, 1TB drives on the server. For the The Office test, I had just stopped the recording service to put in the patched NextPVR.exe, then restarted it, then launched a new NMT/mvp session. And my config.xml settings have

Code:

<AutoRemoveMissingRecordings>true</AutoRemoveMissingRecordings>
    <CheckForRenamedRecordings>true</CheckForRenamedRecordings>

So, unless I'm missing something, NPVR should have just "touched" each of the recordings to verify its existence. So, it should not be a problem with one of the drives being spun down.

So I'm confused as to why sometimes deleting the .ts file is taking 7-10 seconds and then other times its only 1-2 seconds. :confused:

[sub]

2011-07-17 09:50:59.954 [DEBUG][6] -removing: E:\NPVR Recordings\Big Brother\Big Brother_20110707_20002100.ts
2011-07-17 09:51:06.459 [DEBUG][6] -removing: E:\NPVR Recordings\Big Brother\Big Brother_20110707_20002100.txt

There is absolutely nothing between those two log lines other than using the Windows API to delete the file, so it does look like it's caused by some delay introduced by your drive, or Windows.

[johnsonx42]

perhaps it's just waiting for the drive to spin up?

[mvallevand]

There is absolutely nothing between those two log lines other than using the Windows API to delete the file, so it does look like it's caused by some delay introduced by your drive, or Windows.

It probably just needs a ForceRender()

Martin

[johnsonx42]

I hope there won't be too many popups, the Recording Sort popup just seems in the way IMO. I watch the background list anyway since the popup text doesn't always match what I see on screen.

I agree about the sorting pop-up; the problem with it is that it stays on-screen too long. The Sort is done in a 1/2 second, yet the pop-up sits there for ten times longer. But that's not a please-wait pop-up, it's specifically telling what what sort order you've got selected. It just needs to go away much sooner; since the text of the pop-up is just 2 or 3 words, it only needs to be there for literally one second at most. Alternately if the sort order were simply displayed somewhere on the screen in small text, then the text could just change as the sort order does. The latter would be better - the pop-up for this particular function feels discordant.

NPVR really does need some sort of busy indication though. Pressing a button and then having to wait and wonder whether or not it's doing anything really destroys the user experience. If not a pop-up window, then perhaps a busy indicator somewhere on the screen, maybe one of the upper corners.

[BrettB]

Alternately if the sort order were simply displayed somewhere on the screen in small text, then the text could just change as the sort order does. The latter would be better - the pop-up for this particular function feels discordant.

I really like the idea of full-time display indicator. Then each skin developer could have his/her own icons and display location to fit with that skin. Just something like small up or down arrows with an "A" or a little month-like calendar next to them would make nice icons for it. And on the default recordings screen the icon could be on the left side of the status bar at the bottom.