can't view ending of comskipped files

[Brian_W]

By the way, I told my wife about the 999 thing... all of a sudden she had a total melt down... her comment was "how on Earth can sub know that we press 999 on *our* remote?"

HAHA oh man, those are always good.

Brian

[Jim_]

Yeah, I think you're right. Its not displaying the last commercial if its past the duration of the video, but still doing the skip. I'll modify the next build so that it wont do that skip, so that its consistant with what is displayed.

Please don't make this change.:eek:

My commercial skipping is properly tuned and quite frequently the last commercial extends to the end of the video.
Wouldn’t it be better to display the “graphic” to the end of the timeline, even if it extends past what gbpvr calculates to be the end of the video?
For me, seeing the last commercial on the timeline isn’t nearly as important as skipping it.

[stefan]

That might be better if it's possible. The problem is in the few cases when comskip is off a bit, and marks too much of the end as being a commercial... then there is no way to watch that part of the show, since every time you try to go there (by playing the file, or by skipping 1 minute into it or something), gbpvr skips all the way to the end... Of course, with the 999 option, there is a workaround for that

[Jim_]

That might be better if it's possible. The problem is in the few cases when comskip is off a bit, and marks too much of the end as being a commercial... then there is no way to watch that part of the show, since every time you try to go there (by playing the file, or by skipping 1 minute into it or something), gbpvr skips all the way to the end... Of course, with the 999 option, there is a workaround for that

It would be very simple to write a utility that could chop a few seconds off the last commercial, if it extends through the end of the video.
That way, everyone else wouldn’t have to have comskip permanently and automatically disabled.

I have a feeling this issue is also related to the “resume” option always coming up with 98.8, even after a video is played completely to the end. The same end-time calculations?

[stefan]

It would be very simple to write a utility that could chop a few seconds off the last commercial, if it extends through the end of the video.

That would probably be for the best. Maybe we could get Erik to include an option in comskip to do this...

[Jim_]

That would probably be for the best. Maybe we could get Erik to include an option in comskip to do this...

I bet he would do it for us.
Soemthing like this
IfEndOfVideoRemove=30 (frames)

[proteus5]

Yeah, I think you're right. Its not displaying the last commercial if its past the duration of the video, but still doing the skip. I'll modify the next build so that it wont do that skip, so that its consistant with what is displayed.

This would be great, I've also had this problem once in a while. My workaround was to set the post padding to 4 minutes. This way there is enough of the last commercial break for comskip to process, but it does cause some overlapping problems with recording consecutive shows. Also the "999" to toggle auto comskip from the remote is great and I look forward to that.

Thanks Sub!!!!!!

[sub]

Please don't make this change.:eek:

Why did I know someone was going to say that... No matter what the change, any change I mention seems to alway have at least one user that would prefer I dont make that change or do something else...

The problem is in the few cases when comskip is off a bit, and marks too much of the end as being a commercial... then there is no way to watch that part of the show, since every time you try to go there (by playing the file, or by skipping 1 minute into it or something), gbpvr skips all the way to the end...

...and this was my reasoning for doing it the way I chose to. Its also very easy to press the stop button when the credits start rolling.

[Jim_]

Why did I know someone was going to say that... No matter what the change, any change I mention seems to alway have at least one user that would prefer I dont make that change or do something else...

I hear ya, there’s always one troublemaker in the crowd. :o
Could I request it as a config.xml option, if possible?
Thanks!

PS.
Wouldn’t this work, for people who consider it (the last commercial break) to be a problem?
http://forums.nextpvr.com/showthread.php?t=19809