Further additions to the Gotham addon

***sub*** · 2013-11-20, 06:53 PM

I've attached another updated Windows build of the Gotham addon. Main change in this update is provide more options while setting up a recurring recording.

Summary of changes since Frodo release:

Quote:- added dialog to set recurring recordings, including recurrence type, padding, number of recordings to keep, and recording directory
- added support for EDL (though not currently called by XBMC)
- added support for retrieving and storing last playback position
- now requires NextPVR 3.1.1 or higher
- fixed a bug that could cause an EPG event with no description to have a copy of last show's description, or cause a crash if the user was unlucky.
- more flexible approach to genre

***sub*** · 2013-11-20, 07:07 PM

Here is the source for anyone wanting to build it on other platforms.

KRA · 2013-11-20, 10:45 PM

Tried to build on linux, failed and as usual I'm clueless. I tried with both your git as a source and opdenkamp

Code:
In file included from src/pvrclient-nextpvr.cpp:28:0:

src/pvrclient-nextpvr.h:54:85: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]

   PVR_ERROR GetEpg(ADDON_HANDLE handle, const PVR_CHANNEL &channel, time_t iStart = NULL, time_t iEnd = NULL);

                                                                                     ^

src/pvrclient-nextpvr.h:54:105: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]

   PVR_ERROR GetEpg(ADDON_HANDLE handle, const PVR_CHANNEL &channel, time_t iStart = NULL, time_t iEnd = NULL);

                                                                                                         ^

src/pvrclient-nextpvr.cpp: In member function 'bool cPVRClientNextPVR::Connect()':

src/pvrclient-nextpvr.cpp:227:128: error: 'stoi' was not declared in this scope

                   m_iDefaultPrePadding = stoi(settingsDoc.RootElement()->FirstChildElement("PrePadding")->FirstChild()->Value());

                                                                                                                                ^

src/pvrclient-nextpvr.cpp: At global scope:

src/pvrclient-nextpvr.cpp:329:11: warning: unused parameter 'localTime' [-Wunused-parameter]

 PVR_ERROR cPVRClientNextPVR::GetBackendTime(time_t *localTime, int *gmtOffset)

           ^

src/pvrclient-nextpvr.cpp:329:11: warning: unused parameter 'gmtOffset' [-Wunused-parameter]

src/pvrclient-nextpvr.cpp: In member function 'PVR_ERROR cPVRClientNextPVR::GetEpg(ADDON_HANDLE, const PVR_CHANNEL&, time_t, time_t)':

src/pvrclient-nextpvr.cpp:354:24: warning: statement has no effect [-Wunused-value]

       for( pListingNode; pListingNode; pListingNode=pListingNode->NextSiblingElement())

                        ^

src/pvrclient-nextpvr.cpp: In member function 'int cPVRClientNextPVR::GetNumChannels()':

src/pvrclient-nextpvr.cpp:440:24: warning: statement has no effect [-Wunused-value]

       for( pChannelNode; pChannelNode; pChannelNode=pChannelNode->NextSiblingElement())

                        ^

src/pvrclient-nextpvr.cpp: In member function 'PVR_ERROR cPVRClientNextPVR::GetChannels(ADDON_HANDLE, bool)':

src/pvrclient-nextpvr.cpp:544:24: warning: statement has no effect [-Wunused-value]

       for( pChannelNode; pChannelNode; pChannelNode=pChannelNode->NextSiblingElement())

                        ^

src/pvrclient-nextpvr.cpp: In member function 'int cPVRClientNextPVR::GetChannelGroupsAmount()':

src/pvrclient-nextpvr.cpp:601:22: warning: statement has no effect [-Wunused-value]

       for( pGroupNode; pGroupNode; pGroupNode=pGroupNode->NextSiblingElement())

                      ^

src/pvrclient-nextpvr.cpp: In member function 'PVR_ERROR cPVRClientNextPVR::GetChannelGroups(ADDON_HANDLE, bool)':

src/pvrclient-nextpvr.cpp:628:22: warning: statement has no effect [-Wunused-value]

       for( pGroupNode; pGroupNode; pGroupNode=pGroupNode->NextSiblingElement())

                      ^

src/pvrclient-nextpvr.cpp: In member function 'PVR_ERROR cPVRClientNextPVR::GetChannelGroupMembers(ADDON_HANDLE, const PVR_CHANNEL_GROUP&)':

src/pvrclient-nextpvr.cpp:664:24: warning: statement has no effect [-Wunused-value]

       for( pChannelNode; pChannelNode; pChannelNode=pChannelNode->NextSiblingElement())

                        ^

src/pvrclient-nextpvr.cpp: In member function 'int cPVRClientNextPVR::GetNumRecordings()':

src/pvrclient-nextpvr.cpp:697:28: warning: statement has no effect [-Wunused-value]

         for( pRecordingNode; pRecordingNode; pRecordingNode=pRecordingNode->NextSiblingElement())

                            ^

src/pvrclient-nextpvr.cpp: In member function 'PVR_ERROR cPVRClientNextPVR::GetRecordings(ADDON_HANDLE)':

src/pvrclient-nextpvr.cpp:721:26: warning: statement has no effect [-Wunused-value]

       for( pRecordingNode; pRecordingNode; pRecordingNode=pRecordingNode->NextSiblingElement())

                          ^

src/pvrclient-nextpvr.cpp:768:26: warning: statement has no effect [-Wunused-value]

       for( pRecordingNode; pRecordingNode; pRecordingNode=pRecordingNode->NextSiblingElement())

                          ^

src/pvrclient-nextpvr.cpp: At global scope:

src/pvrclient-nextpvr.cpp:825:11: warning: unused parameter 'recording' [-Wunused-parameter]

 PVR_ERROR cPVRClientNextPVR::RenameRecording(const PVR_RECORDING &recording)

           ^

src/pvrclient-nextpvr.cpp: In member function 'PVR_ERROR cPVRClientNextPVR::GetRecordingEdl(const PVR_RECORDING&, PVR_EDL_ENTRY*, int*)':

src/pvrclient-nextpvr.cpp:873:29: warning: statement has no effect [-Wunused-value]

         for( pCommercialNode; pCommercialNode; pCommercialNode=pCommercialNode->NextSiblingElement())

                             ^

src/pvrclient-nextpvr.cpp:875:105: error: 'stoi' was not declared in this scope

           entries[index].start = stoi(pCommercialNode->FirstChildElement("start")->FirstChild()->Value()) * 1000;

                                                                                                         ^

src/pvrclient-nextpvr.cpp: In member function 'int cPVRClientNextPVR::GetNumTimers()':

src/pvrclient-nextpvr.cpp:906:28: warning: statement has no effect [-Wunused-value]

         for( pRecordingNode; pRecordingNode; pRecordingNode=pRecordingNode->NextSiblingElement())

                            ^

src/pvrclient-nextpvr.cpp:926:28: warning: statement has no effect [-Wunused-value]

         for( pRecordingNode; pRecordingNode; pRecordingNode=pRecordingNode->NextSiblingElement())

                            ^

src/pvrclient-nextpvr.cpp: In member function 'PVR_ERROR cPVRClientNextPVR::GetTimers(ADDON_HANDLE)':

src/pvrclient-nextpvr.cpp:950:26: warning: statement has no effect [-Wunused-value]

       for( pRecurringNode; pRecurringNode; pRecurringNode=pRecurringNode->NextSiblingElement())

                          ^

src/pvrclient-nextpvr.cpp:991:26: warning: statement has no effect [-Wunused-value]

       for( pRecordingNode; pRecordingNode; pRecordingNode=pRecordingNode->NextSiblingElement())

                          ^

src/pvrclient-nextpvr.cpp: At global scope:

src/pvrclient-nextpvr.cpp:1045:11: warning: unused parameter 'timernumber' [-Wunused-parameter]

 PVR_ERROR cPVRClientNextPVR::GetTimerInfo(unsigned int timernumber, PVR_TIMER &timerinfo)

           ^

src/pvrclient-nextpvr.cpp:1045:11: warning: unused parameter 'timerinfo' [-Wunused-parameter]

src/pvrclient-nextpvr.cpp: In member function 'PVR_ERROR cPVRClientNextPVR::AddTimer(const PVR_TIMER&)':

src/pvrclient-nextpvr.cpp:1054:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

   if (timerinfo.iClientIndex != -1)

                                  ^

src/pvrclient-nextpvr.cpp: At global scope:

src/pvrclient-nextpvr.cpp:1137:11: warning: unused parameter 'bForceDelete' [-Wunused-parameter]

 PVR_ERROR cPVRClientNextPVR::DeleteTimer(const PVR_TIMER &timer, bool bForceDelete)

           ^

src/pvrclient-nextpvr.cpp:1161:11: warning: unused parameter 'timerinfo' [-Wunused-parameter]

 PVR_ERROR cPVRClientNextPVR::UpdateTimer(const PVR_TIMER &timerinfo)

           ^

src/pvrclient-nextpvr.cpp: In member function 'bool cPVRClientNextPVR::OpenLiveStream(const PVR_CHANNEL&)':

src/pvrclient-nextpvr.cpp:1244:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

         if (i < sizeof(header))

                              ^

src/pvrclient-nextpvr.cpp: In member function 'int cPVRClientNextPVR::ReadLiveStream(unsigned char*, unsigned int)':

src/pvrclient-nextpvr.cpp:1318:14: warning: unused variable 'available' [-Wunused-variable]

         bool available = m_streamingclient->read_ready();

              ^

src/pvrclient-nextpvr.cpp:1357:51: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

     if (m_incomingStreamBuffer.getMaxReadSize() < read)

                                                   ^

src/pvrclient-nextpvr.cpp: At global scope:

src/pvrclient-nextpvr.cpp:1393:11: warning: unused parameter 'iWhence' [-Wunused-parameter]

 long long cPVRClientNextPVR::SeekLiveStream(long long iPosition, int iWhence)

           ^

src/pvrclient-nextpvr.cpp:1449:11: warning: unused parameter 'signalStatus' [-Wunused-parameter]

 PVR_ERROR cPVRClientNextPVR::SignalStatus(PVR_SIGNAL_STATUS &signalStatus)

           ^

src/pvrclient-nextpvr.cpp: In member function 'bool cPVRClientNextPVR::OpenRecordingInternal(long long int)':

src/pvrclient-nextpvr.cpp:1506:53: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long long int' [-Wformat=]

     sprintf(line, "Range: bytes=%d-\r\n", seekOffset);

                                                     ^

src/pvrclient-nextpvr.cpp:1533:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

         if (i < sizeof(tempHeader))

                                  ^

make[2]: *** [pvrclient-nextpvr.lo] Error 1

***sub*** · 2013-11-20, 11:22 PM

can you edit the file, and see if changing that occurrence of "stoi" to "atoi" helps?

mvallevand · 2013-11-20, 11:26 PM

[quote=KRA]Tried to build on linux, failed and as usual I'm clueless. I tried with both your git as a source and opdenkamp

Code:
src/pvrclient-nextpvr.cpp: In member function 'bool cPVRClientNextPVR::Connect()':

src/pvrclient-nextpvr.cpp:227:128: error: 'stoi' was not declared in this scope

                   m_iDefaultPrePadding = stoi(settingsDoc.RootElement()->FirstChildElement("PrePadding")->FirstChild()->Value());

                                                                                                                                ^

What version of gcc are you using?

Martin

KRA · 2013-11-21, 05:21 PM

gcc:
Installed: 4:4.8.1-2ubuntu3

I changed all stoi to atoi in pvrclient-nextpvr.cpp and it compiled, but there where still warnings.

KRA · 2013-11-21, 05:36 PM

Seems to work, not tested if the settings in fact work, but they do show up in xbmc.

Linux build (with Norwegian language in addition to English)

Install from zip doesn't seem to work (version conflict ??) Manual install is needed.

KRA · 2013-11-22, 04:26 PM

ok, I've done some quick testing now, been busy for some days. I don't know if this is related to my special xbmc build. My compile warnings or some other error. But when I try advanced rules I get message. "The PVR backend does not support this action. Check the log for details. An unexpexted error occurred.

Will test more later.

***sub*** · 2013-11-22, 04:36 PM

KRA Wrote:ok, I've done some quick testing now, been busy for some days. I don't know if this is related to my special xbmc build. My compile warnings or some other error. But when I try advanced rules I get message. "The PVR backend does not support this action. Check the log for details. An unexpexted error occurred.

What type of recording did you try to schedule? You'll need to supply the debug xbmc log, and the NextPVR web.log.

KRA · 2013-11-23, 11:17 AM

I had a look at the logs, tried "record all new shows" and "record all new shows on weeked" just now, with debug log and this is what I found interesting in the log, tell me if you want the complete log.

web.log:

Code:
2013-11-23 12:01:29.814    [DEBUG][3]    Got Web Request (192.168.10.115): /service    method=recording.recurring.save&event_id=1217487&recurring_type=2&keep=0&pre_padding=1&post_padding=2&directory_id=[Default]&sid=e422774acfbe4899ab780dab4ba3de86

2013-11-23 12:01:29.814    [DEBUG][3]    method=recording.recurring.save

2013-11-23 12:01:29.814    [DEBUG][3]    parameters: 

2013-11-23 12:01:29.814    [DEBUG][3]       method: recording.recurring.save

2013-11-23 12:01:29.814    [DEBUG][3]       event_id: 1217487

2013-11-23 12:01:29.814    [DEBUG][3]       recurring_type: 2

2013-11-23 12:01:29.814    [DEBUG][3]       keep: 0

2013-11-23 12:01:29.814    [DEBUG][3]       pre_padding: 1

2013-11-23 12:01:29.814    [DEBUG][3]       post_padding: 2

2013-11-23 12:01:29.814    [DEBUG][3]       directory_id: [Default]

2013-11-23 12:01:29.814    [DEBUG][3]       sid: e422774acfbe4899ab780dab4ba3de86

2013-11-23 12:01:29.814    [DEBUG][3]       client_ip: 192.168.10.115

2013-11-23 12:01:29.814    [DEBUG][3]       host_callback: 192.168.10.204:8866

2013-11-23 12:01:29.814    [DEBUG][3]       physical_path: C:\Users\Public\NPVR\web\

2013-11-23 12:01:29.814    [DEBUG][3]       user_agent: XBMC/13.0-ALPHA10 Git:557255d (Linux; Ubuntu 13.10; 3.11.0-13-generic x86_64; http://xbmc.org)

2013-11-23 12:01:29.814    [DEBUG][3]       range: bytes=0-

2013-11-23 12:01:29.814    [DEBUG][3]       requested_path: /service

2013-11-23 12:01:29.814    [DEBUG][3]       verb: GET

2013-11-23 12:01:29.814    [ERROR][3]    event_id is invalid

2013-11-23 12:01:29.814    [DEBUG][3]    <?xml version="1.0" encoding="utf-8" ?>

<rsp stat="fail">

  <err code="2" msg="Invalid Args" />

</rsp>

2013-11-23 12:01:43.074    [DEBUG][4]    Got Web Request (192.168.10.115): /service    method=recording.recurring.save&event_id=1217487&recurring_type=6&keep=0&pre_padding=1&post_padding=2&directory_id=[Default]&sid=e422774acfbe4899ab780dab4ba3de86

2013-11-23 12:01:43.074    [DEBUG][4]    method=recording.recurring.save

2013-11-23 12:01:43.074    [DEBUG][4]    parameters: 

2013-11-23 12:01:43.074    [DEBUG][4]       method: recording.recurring.save

2013-11-23 12:01:43.074    [DEBUG][4]       event_id: 1217487

2013-11-23 12:01:43.074    [DEBUG][4]       recurring_type: 6

2013-11-23 12:01:43.074    [DEBUG][4]       keep: 0

2013-11-23 12:01:43.074    [DEBUG][4]       pre_padding: 1

2013-11-23 12:01:43.074    [DEBUG][4]       post_padding: 2

2013-11-23 12:01:43.074    [DEBUG][4]       directory_id: [Default]

2013-11-23 12:01:43.074    [DEBUG][4]       sid: e422774acfbe4899ab780dab4ba3de86

2013-11-23 12:01:43.074    [DEBUG][4]       client_ip: 192.168.10.115

2013-11-23 12:01:43.074    [DEBUG][4]       host_callback: 192.168.10.204:8866

2013-11-23 12:01:43.074    [DEBUG][4]       physical_path: C:\Users\Public\NPVR\web\

2013-11-23 12:01:43.074    [DEBUG][4]       user_agent: XBMC/13.0-ALPHA10 Git:557255d (Linux; Ubuntu 13.10; 3.11.0-13-generic x86_64; http://xbmc.org)

2013-11-23 12:01:43.074    [DEBUG][4]       range: bytes=0-

2013-11-23 12:01:43.074    [DEBUG][4]       requested_path: /service

2013-11-23 12:01:43.074    [DEBUG][4]       verb: GET

2013-11-23 12:01:43.074    [ERROR][4]    event_id is invalid

2013-11-23 12:01:43.074    [DEBUG][4]    <?xml version="1.0" encoding="utf-8" ?>

<rsp stat="fail">

  <err code="2" msg="Invalid Args" />

</rsp>

xbmc.log:

Code:
01:43 T:139939084994432   DEBUG: ------ Window Deinit (/home/kay/.xbmc/addons/pvr.nextpvr/resources/skins/skin.confluence/720p/RecordPrefs.xml) ------

01:43 T:139939084994432   DEBUG: CFileCache::Open - opening <service> using cache

01:43 T:139939084994432   DEBUG: CurlFile::Open(0x2e44fc0) http://192.168.10.204:8866/service?method=recording.recurring.save&event_id=1217487&recurring_type=6&keep=0&pre_padding=1&post_padding=2&directory_id=[Default]&sid=e422774acfbe4899ab780dab4ba3de86

01:43 T:139938459154176  NOTICE: Thread FileCache start, auto delete: false

01:43 T:139938459154176    INFO: CFileCache::Process - Hit eof.

01:43 T:139938459154176   DEBUG: Thread FileCache 139938459154176 terminating

01:43 T:139939084994432   ERROR: PVR - AddTimer - addon '192.168.10.204:connected' returned an error: the command failed

01:43 T:139939084994432   ERROR: PVR - AddTimer - cannot add timer to client '2': the command failed

01:43 T:139939084994432   DEBUG: ------ Window Init (DialogOK.xml) ------

02:13 T:139939084994432    INFO: CheckIdle - Closing session to http://192.168.10.204 (easy=0x7f45e00683b0, multi=0x7f45e0071130)

Possibly Related Threads…
Thread		Author	Replies	Views	Last Post
	Kodi Addon Failure 19.0.4	Luke86	4	1,708	2022-10-22, 03:33 AM Last Post: Luke86
	Kodi NextPVR PVR Client Addon	solfanboy	11	3,777	2022-07-11, 08:51 PM Last Post: mvallevand
	NextPVR addon: session.login failed	spagio	3	3,628	2022-04-30, 05:47 PM Last Post: mvallevand
	Where is the Kodi NPVR addon timeline duration stored?	Lao Pan	4	1,680	2021-01-11, 10:19 AM Last Post: mvallevand
	nextpvr pvr addon v7.1.1 android kodi	a1blues	5	2,615	2020-10-22, 06:17 PM Last Post: mvallevand
	Kodi Matrix Alpha 1 Offers NPVR Addon v 7.0.0 but can't install	Lao Pan	1	1,451	2020-09-27, 10:50 PM Last Post: mvallevand
	KODI PVR addon supporting in progress recordings	JP23	28	8,128	2020-06-25, 06:37 PM Last Post: mvallevand
	Addon Couldn't be Loaded. An unknown error occurred	Kattz	2	3,043	2020-05-30, 04:13 PM Last Post: sub
	set mac address in nextpvr addon	2leftfeet	19	7,495	2020-04-18, 04:31 PM Last Post: 2leftfeet
	KODI NPVR Addon misbehaving	elstaci	34	8,532	2020-03-09, 07:33 PM Last Post: elstaci